[
https://issues.apache.org/jira/browse/STORM-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697780#comment-14697780
]
ASF GitHub Bot commented on STORM-976:
--------------------------------------
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/684#issuecomment-131242201
I looked through the branch and found some I hadn't noticed before:
*
[logback.xml](https://github.com/apache/storm/blob/aa308e11685b8b7945f2d4963e9f63dfd322087b/external/flux/flux-core/src/test/resources/logback.xml)
file under flux is still there. We could fix this separately in another JIRA
since it is external. If we can fix it now, then that is even better.
*
[FAQ.md](https://github.com/apache/storm/blob/aa308e11685b8b7945f2d4963e9f63dfd322087b/docs/documentation/FAQ.md)
already mentions moving to logback from log4j (1.x), so we should update that
one part since we have moved again to log4j2.
*
[SECURITY.md](https://github.com/apache/storm/blob/aa308e11685b8b7945f2d4963e9f63dfd322087b/SECURITY.md)
also mentions logback in one spot. We could change it or make it generic.
It would be nice to take care of these three as part of this work,
otherwise we can create another JIRA Issue to track.
> Config storm.logback.conf.dir is specific to previous logging framework
> -----------------------------------------------------------------------
>
> Key: STORM-976
> URL: https://issues.apache.org/jira/browse/STORM-976
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Derek Dagit
> Priority: Minor
> Labels: Newbie
>
> Storm has migrated from logback to log4j2, so we should rename this config
> and code that uses it.
> https://github.com/apache/storm/blob/544e55cb8ab8878c4af500aab49bd35d4b69cd3e/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L664
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
