[
https://issues.apache.org/jira/browse/STORM-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697965#comment-14697965
]
ASF GitHub Bot commented on STORM-976:
--------------------------------------
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/684#discussion_r37129089
--- Diff: bin/storm-config.cmd ---
@@ -83,10 +83,10 @@ if not defined STORM_LOG_DIR (
)
@rem
-@rem retrieve storm.logback.conf.dir from conf file
+@rem retrieve storm.log4j2.conf.dir from conf file
@rem
-"%JAVA%" -client -Dstorm.options= -Dstorm.conf.file= -cp "%CLASSPATH%"
backtype.storm.command.config_value storm.logback.conf.dir > %CMD_TEMP_FILE%
+"%JAVA%" -client -Dstorm.options= -Dstorm.conf.file= -cp "%CLASSPATH%"
backtype.storm.command.config_value storm.log4j2.conf.dir > %CMD_TEMP_FILE%
--- End diff --
+1 for fixing these things now. Configuration (logs and otherwise) are a
big stumbling block for new users. Anything we can do to alleviate such things
would be good.
> Config storm.logback.conf.dir is specific to previous logging framework
> -----------------------------------------------------------------------
>
> Key: STORM-976
> URL: https://issues.apache.org/jira/browse/STORM-976
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Derek Dagit
> Priority: Minor
> Labels: Newbie
>
> Storm has migrated from logback to log4j2, so we should rename this config
> and code that uses it.
> https://github.com/apache/storm/blob/544e55cb8ab8878c4af500aab49bd35d4b69cd3e/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L664
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
