Github user Parth-Brahmbhatt commented on a diff in the pull request:

    https://github.com/apache/storm/pull/673#discussion_r37217915
  
    --- Diff: storm-core/src/storm.thrift ---
    @@ -349,6 +351,7 @@ service Nimbus {
       void activate(1: string name) throws (1: NotAliveException e, 2: 
AuthorizationException aze);
       void deactivate(1: string name) throws (1: NotAliveException e, 2: 
AuthorizationException aze);
       void rebalance(1: string name, 2: RebalanceOptions options) throws (1: 
NotAliveException e, 2: InvalidTopologyException ite, 3: AuthorizationException 
aze);
    +  void debug(1: string name, 2: string component, 3: bool enable) throws 
(1: NotAliveException e, 2: AuthorizationException aze);
    --- End diff --
    
    Can you add a comment here to indicate that component name is optional ( 
can be null or empty) and when it is null the debug flag will apply to entire 
topology?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to