Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/673#discussion_r37845257
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/common.clj ---
    @@ -273,6 +293,26 @@
          (metrics-consumer-register-ids storm-conf)
          (get storm-conf TOPOLOGY-METRICS-CONSUMER-REGISTER))))
     
    +;; return the fields that event logger bolt expects
    +(defn eventlogger-bolt-fields []
    +  [(EventLoggerBolt/FIELD_COMPONENT_ID)  (EventLoggerBolt/FIELD_TS) 
(EventLoggerBolt/FIELD_VALUES)]
    +  )
    +
    +(defn add-eventlogger! [storm-conf ^StormTopology ret]
    +  (let [num-executors (if (nil? (storm-conf 
TOPOLOGY-EVENTLOGGER-EXECUTORS)) (storm-conf TOPOLOGY-WORKERS) (storm-conf 
TOPOLOGY-EVENTLOGGER-EXECUTORS))
    --- End diff --
    
    I followed similar logic as "add-acker!". When num-executors is set to 0, 
no threads would execute the task. Verified it by setting the value to 0 and no 
event logger tasks ran.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to