Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/700#issuecomment-135577332
Addressed comments:
a. Removed the config of suspend time, reuse the empty emit and put the
judgement together with max.spout.pending
b. Separate functions for credentials and throttle checks in
schedule-recurring thread
c. Update worker flag to ZK only when it has changed (for reducing ZK load)
d. Other comments like type hint and And.
To continue work on the other three comments:
a. Add metrics for executor's suspending times for throttle-on, inactive,
spout.spending etc.
b. Concern on the possible corner cases since I put the backpressure checks
in tuple-action-fn.
c. Unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
