Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/700#discussion_r38126936
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -811,9 +841,18 @@
(setup-metrics! executor-data)
(let [receive-queue (:receive-queue executor-data)
- event-handler (mk-task-receiver executor-data
tuple-action-fn)]
+ event-handler (mk-task-receiver executor-data
tuple-action-fn)
+ high-watermark ((:storm-conf executor-data)
BACKPRESSURE-EXECUTOR-HIGH-WATERMARK)
+ low-watermark ((:storm-conf executor-data)
BACKPRESSURE-EXECUTOR-LOW-WATERMARK)
+ receive-queue-size ((:storm-conf executor-data)
TOPOLOGY-EXECUTOR-RECEIVE-BUFFER-SIZE)
+ high-watermark (int (* high-watermark receive-queue-size))
+ low-watermark (int (* low-watermark receive-queue-size))]
(disruptor/consumer-started! receive-queue)
(fn []
+ ;; this additional check is necessary because rec-q can be 0
while the executor backpressure flag is forever set
+ (if (and ((:storm-conf executor-data)
TOPOLOGY-BACKPRESSURE-ENABLE) (< (.population receive-queue) low-watermark)
@(:backpressure executor-data))
--- End diff --
Can we move the `and` form's second condition to a new line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
