[
https://issues.apache.org/jira/browse/STORM-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720546#comment-14720546
]
ASF GitHub Bot commented on STORM-1013:
---------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/707#issuecomment-135885006
@alexpanov
Nice work. I have some comments for this PR,
1.
I found you're refactoring whole codes which I think is better to file
several new issues to JIRA respectively.
Please keep diffs simple and small enough, and try to avoid introducing
unrelated diffs.
2.
Seems like you need to update your working directory before starting.
I merged #679 into master after merging #693, which was conflicted.
3. storm-core relocates guava's package for avoiding conflicts.
I'm not 100% sure, but I think it means that if we need to use guava from
outer of storm-core, guava should be added as dependency explicitly.
Any other external modules already did it, though I think it would be
better to relocate guava again.
> [storm-elasticsearch] Expose TransportClient configuration Map to EsConfig
> --------------------------------------------------------------------------
>
> Key: STORM-1013
> URL: https://issues.apache.org/jira/browse/STORM-1013
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Jungtaek Lim
> Assignee: Alex Panov
> Priority: Minor
>
> storm-elasticsearch has hardcoded configuration for TransportClient,
> client.transport.sniff = true.
> Users may want to change this value, and may also want to add another
> configuration.
> (Please refer
> https://www.elastic.co/guide/en/elasticsearch/client/java-api/current/transport-client.html)
> If we want to pass configurations to TransportClient, I think it would be
> better to expose Map from EsConfig, and put all things inside Map to
> ImmutableSettings.settingsBuilder().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
