[
https://issues.apache.org/jira/browse/STORM-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721476#comment-14721476
]
ASF GitHub Bot commented on STORM-1013:
---------------------------------------
Github user alexpanov commented on the pull request:
https://github.com/apache/storm/pull/707#issuecomment-136124914
@HeartSaVioR
1. No problem. Will do.
2. Done.
3. I used ES Preconditions instead. It's already in the classpath anyway.
I also updated documentation for the EsConfig (since I have made it
immutable previously).
> [storm-elasticsearch] Expose TransportClient configuration Map to EsConfig
> --------------------------------------------------------------------------
>
> Key: STORM-1013
> URL: https://issues.apache.org/jira/browse/STORM-1013
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Jungtaek Lim
> Assignee: Alex Panov
> Priority: Minor
>
> storm-elasticsearch has hardcoded configuration for TransportClient,
> client.transport.sniff = true.
> Users may want to change this value, and may also want to add another
> configuration.
> (Please refer
> https://www.elastic.co/guide/en/elasticsearch/client/java-api/current/transport-client.html)
> If we want to pass configurations to TransportClient, I think it would be
> better to expose Map from EsConfig, and put all things inside Map to
> ImmutableSettings.settingsBuilder().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
