[
https://issues.apache.org/jira/browse/STORM-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732402#comment-14732402
]
ASF GitHub Bot commented on STORM-1032:
---------------------------------------
Github user ddebree commented on a diff in the pull request:
https://github.com/apache/storm/pull/723#discussion_r38822071
--- Diff:
storm-core/src/jvm/backtype/storm/drpc/LinearDRPCTopologyBuilder.java ---
@@ -174,13 +174,12 @@ private static String boltId(int index) {
private static class Component {
public IRichBolt bolt;
public int parallelism;
- public List<Map> componentConfs;
+ public List<Map<String, Object>> componentConfs = new
ArrayList<>();
public List<InputDeclaration> declarations = new
ArrayList<InputDeclaration>();
public Component(IRichBolt bolt, int parallelism) {
this.bolt = bolt;
this.parallelism = parallelism;
- this.componentConfs = new ArrayList();
--- End diff --
I moved this to line 177 above to make it slightly cleaner
> Add generics to component configuration methods
> -----------------------------------------------
>
> Key: STORM-1032
> URL: https://issues.apache.org/jira/browse/STORM-1032
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Dean de Bree
> Assignee: Dean de Bree
> Priority: Minor
>
> The getComponentConfiguration methods currently return a simple Map object.
> In fact they should be returning a Map<String, Object>.
> By changing this, it will make it slightly clear what is being returned by
> the method and potentially pick up some issues at compile time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
