[
https://issues.apache.org/jira/browse/STORM-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732403#comment-14732403
]
ASF GitHub Bot commented on STORM-1032:
---------------------------------------
Github user ddebree commented on a diff in the pull request:
https://github.com/apache/storm/pull/723#discussion_r38822073
--- Diff:
storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java ---
@@ -204,7 +204,7 @@ public StormTopology buildTopology() {
for(String id: _bolts.keySet()) {
Component c = _bolts.get(id);
- Map<String, CoordSpec> specs = new HashMap();
+ Map<String, CoordSpec> specs = new HashMap<>();
--- End diff --
Another minor generics fix.
> Add generics to component configuration methods
> -----------------------------------------------
>
> Key: STORM-1032
> URL: https://issues.apache.org/jira/browse/STORM-1032
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Dean de Bree
> Assignee: Dean de Bree
> Priority: Minor
>
> The getComponentConfiguration methods currently return a simple Map object.
> In fact they should be returning a Map<String, Object>.
> By changing this, it will make it slightly clear what is being returned by
> the method and potentially pick up some issues at compile time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
