[ 
https://issues.apache.org/jira/browse/STORM-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14747207#comment-14747207
 ] 

ASF GitHub Bot commented on STORM-1044:
---------------------------------------

GitHub user mjsax opened a pull request:

    https://github.com/apache/storm/pull/740

    [STORM-1044] Setting dop to zero does not raise an error

     - added IllegalArgumentException to .setBolt(...), .setSpout(...), and 
.setStateSpout(...) in TopologyBuilder

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mjsax/storm storm-1044-dop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #740
    
----
commit 8ed57abb5a13cf59a66fb7eb3339b27ec2fe3e60
Author: mjsax <[email protected]>
Date:   2015-09-15T11:56:56Z

    [STORM-1044] Setting dop to zero does not raise an error
     - added IllegalArgumentException to .setBolt(...), .setSpout(...), and 
.setStateSpout(...) in TopologyBuilder

----


> Setting dop to zero does not raise an error
> -------------------------------------------
>
>                 Key: STORM-1044
>                 URL: https://issues.apache.org/jira/browse/STORM-1044
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> While I did some testing (with automatic topology plugging code) I set the 
> dop of all spouts and bolts to zero. I submitted the topology to 
> {{LocalCluster}} and did not get any error.
> It took me a while to figure out that the wrongly specified dop were the 
> reason for an empty result of the test. From a user point of view, it would 
> be nice to raise an exception when the {{parallelism_hint}} is smaller than 1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to