[
https://issues.apache.org/jira/browse/STORM-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900095#comment-14900095
]
ASF GitHub Bot commented on STORM-1044:
---------------------------------------
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/storm/pull/740#discussion_r39935812
--- Diff: storm-core/test/clj/backtype/storm/nimbus_test.clj ---
@@ -846,16 +846,6 @@
NIMBUS-SLOTS-PER-TOPOLOGY 8}]
(letlocals
(bind topology (thrift/mk-topology
- {"1" (thrift/mk-spout-spec (TestPlannerSpout.
true) :parallelism-hint 0 :conf {TOPOLOGY-TASKS 1})}
--- End diff --
Removed this test because it now throws different exception and this is
tested in the new unit test I added for `TopologyBuilder`. Actually, I tried to
change the expected exception, but this did not fix this test for me (the test
fails if I change `InvalidTopologyException` to `IllegalArgumentException`).
Don't know why. But I am still new to Clojure and Clojure tests.
> Setting dop to zero does not raise an error
> -------------------------------------------
>
> Key: STORM-1044
> URL: https://issues.apache.org/jira/browse/STORM-1044
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> While I did some testing (with automatic topology plugging code) I set the
> dop of all spouts and bolts to zero. I submitted the topology to
> {{LocalCluster}} and did not get any error.
> It took me a while to figure out that the wrongly specified dop were the
> reason for an empty result of the test. From a user point of view, it would
> be nice to raise an exception when the {{parallelism_hint}} is smaller than 1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
