Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/736#discussion_r39639834
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -30,38 +30,6 @@
<useProjectArtifact>false</useProjectArtifact>
<outputDirectory>lib</outputDirectory>
<unpack>false</unpack>
- <excludes>
--- End diff --
Yes, the issue was partly that we didn't shade the libraries properly, but
also we had excludes in there that were not needed. The build would print out
lots of warning that we were excluding things that were not a part of the
dependency list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
