[
https://issues.apache.org/jira/browse/STORM-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803181#comment-14803181
]
ASF GitHub Bot commented on STORM-1012:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/736#issuecomment-141142255
@ptgoetz There were a number of issues.
We were shading dependencies of dependencies without shading the direct
dependency. This resulted in shaded classes leaking into user facing APIs.
We were not using the storm-core dependency reduced pom to build other
components (flux most notably). This resulted in flux assuming that
dependencies would be there when they were not.
We also were partially shading some of our clojure dependencies. Our
dependency clojure code was being compiled into .class files placed in our jar.
The packages for these dependencies were being shaded, but the maven dependency
was not listed, so it was not removed from the dependency reduced pom.
There are also some issues with the ClojureTransformer where it would not
correctly shade clojure code when the package name is split up in the .clj
file, so to work around that we removed the majority of .clj files from the
uber jar.
> Shade Jackson dependency
> ------------------------
>
> Key: STORM-1012
> URL: https://issues.apache.org/jira/browse/STORM-1012
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
> Fix For: 0.11.0
>
>
> Shading jackson dependency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
