[
https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14875907#comment-14875907
]
ASF GitHub Bot commented on STORM-1051:
---------------------------------------
GitHub user schonfeld opened a pull request:
https://github.com/apache/storm/pull/745
[STORM-1051] Fix for flushMessagse NPE
STORM-763 introduced a situation in which flushMessages could receive batch
= null, in which case, an NPE is thrown because we weren't validating != null
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schonfeld/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #745
----
commit 8b845392e920d753eb24fcffead0263416bc6227
Author: Michael Schonfeld <[email protected]>
Date: 2015-09-18T16:31:32Z
[STORM-1051] Fix for flushMessagse NPE
----
> Netty Client.java's flushMessages produces a NullPointerException
> -----------------------------------------------------------------
>
> Key: STORM-1051
> URL: https://issues.apache.org/jira/browse/STORM-1051
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0, 0.9.6
> Reporter: Michael Schonfeld
> Assignee: Michael Schonfeld
>
> STORM-763 replaced `return batch != null && !batch.isEmpty();` with
> `if(batch.isEmpty())`... which means that if batch == null, a
> NullPointerException is thrown. Problem is, batch is often null, which means
> that 763 made Storm unusable...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
