[ 
https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876702#comment-14876702
 ] 

ASF GitHub Bot commented on STORM-1051:
---------------------------------------

Github user schonfeld commented on the pull request:

    https://github.com/apache/storm/pull/745#issuecomment-141595905
  
    Ah, ok! Here's what it looked like in our logs, just in case someone else 
tries to Google the exception at some point...
    
    ```
    2015-09-17 15:03:22 b.s.m.n.StormClientHandler [INFO] Connection failed 
Netty-Client-/10.244.114.24:6703
    java.lang.NullPointerException
      at backtype.storm.messaging.netty.Client.flushMessages(Client.java:320) 
~[storm-core-0.10.1-SNAPSHOT.jar:0.10.1-SNAPSHOT]
      at 
backtype.storm.messaging.netty.Client.notifyInterestChanged(Client.java:455) 
~[storm-core-0.10.1-SNAPSHOT.jar:0.10.1-SNAPSHOT]
      at 
backtype.storm.messaging.netty.StormClientHandler.channelInterestChanged(StormClientHandler.java:36)
 ~[storm-core-0.10.1-SNAPSHOT.jar:0.10.1-SNAPSHOT]
      at 
org.apache.storm.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:106)
 ~[storm-core-0.10.1-SNAPSHOT.jar:0.10.1-SNAPSHOT]
    ```


> Netty Client.java's flushMessages produces a NullPointerException
> -----------------------------------------------------------------
>
>                 Key: STORM-1051
>                 URL: https://issues.apache.org/jira/browse/STORM-1051
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0, 0.9.6
>            Reporter: Michael Schonfeld
>            Assignee: Michael Schonfeld
>            Priority: Critical
>
> STORM-763 replaced `return batch != null && !batch.isEmpty();` with 
> `if(batch.isEmpty())`... which means that if batch == null, a 
> NullPointerException is thrown. Problem is, batch is often null, which means 
> that 763 made Storm unusable...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to