[
https://issues.apache.org/jira/browse/STORM-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941692#comment-14941692
]
ASF GitHub Bot commented on STORM-1086:
---------------------------------------
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/780#discussion_r41063314
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/FailedMsgRetryManagerConfig.java ---
@@ -0,0 +1,7 @@
+package storm.kafka;
+
+import java.io.Serializable;
+
+public interface FailedMsgRetryManagerConfig extends Serializable {
--- End diff --
Since this a factory pattern, I would rename this
`FailedMsgRetryManagerFactory`, and the impl
`ExponentialBackoffMsgRetryManagerFactory`.
> Make FailedMsgRetryManager configurable when setting up KafkaSpout
> ------------------------------------------------------------------
>
> Key: STORM-1086
> URL: https://issues.apache.org/jira/browse/STORM-1086
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Reporter: Nick Kleinschmidt
> Assignee: Nick Kleinschmidt
> Priority: Minor
>
> The FailedMsgRetryManager interface makes replay behavior configurable and we
> default to using ExponentialBackoffMsgRetryManager, but there's no way to
> define your own FailedMsgRetryManager and plug it in when setting up
> KafkaSpout.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
