[
https://issues.apache.org/jira/browse/STORM-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953806#comment-14953806
]
ASF GitHub Bot commented on STORM-1086:
---------------------------------------
Github user kleinsch commented on the pull request:
https://github.com/apache/storm/pull/780#issuecomment-147531078
I wasn't sure if I could make a non-backwards compatible change to
SpoutConfig, but seems like a good idea to move the implementation-specific
code out of there.
Renamed to FailedMsgRetryManagerFactory and moved params for the
exponential backoff manager into the ExponentialBackoffMsgRetryManagerFactory.
This needs to stay a factory bc the SpoutConfig has to be serialized to be
sent out to the nodes, then construct the FailedMsgRetryManager per-node. I
didn't want to require that the FailedMsgRetryManager be serializable, so said
the Factory would be serializable but the RetryManager doesn't need to be.
> Make FailedMsgRetryManager configurable when setting up KafkaSpout
> ------------------------------------------------------------------
>
> Key: STORM-1086
> URL: https://issues.apache.org/jira/browse/STORM-1086
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Reporter: Nick Kleinschmidt
> Assignee: Nick Kleinschmidt
> Priority: Minor
>
> The FailedMsgRetryManager interface makes replay behavior configurable and we
> default to using ExponentialBackoffMsgRetryManager, but there's no way to
> define your own FailedMsgRetryManager and plug it in when setting up
> KafkaSpout.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
