[
https://issues.apache.org/jira/browse/STORM-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942937#comment-14942937
]
ASF GitHub Bot commented on STORM-1073:
---------------------------------------
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/767#discussion_r41111208
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
---
@@ -34,13 +37,11 @@
import org.slf4j.LoggerFactory;
import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Map;
-import java.util.Timer;
-import java.util.TimerTask;
+import java.util.*;
--- End diff --
Better not to use wildcard imports.
> SequenceFileBolt can end up in an unrecoverable state
> -----------------------------------------------------
>
> Key: STORM-1073
> URL: https://issues.apache.org/jira/browse/STORM-1073
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hdfs
> Reporter: Aaron Dossett
> Assignee: Aaron Dossett
>
> SequenceFileBolt has the same issues that HdfsBolt has in STORM-969. This is
> also an opportunity to refactor AbstractHdfsBolt to most efficiently include
> these changes:
> Abstract HdfsBolt should define a concrete execute method and define abstract
> methods for:
> - writing a tuple
> - syncronizing file output
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
