[
https://issues.apache.org/jira/browse/STORM-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965135#comment-14965135
]
ASF GitHub Bot commented on STORM-1073:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/767#issuecomment-149576539
@dossett the code looks fine. I have two minor nits, but they both existed
in the previous code prior to the re-factor so I am +1 either way.
The build failure looks like it was a network hiccup with the maven
repository.
> SequenceFileBolt can end up in an unrecoverable state
> -----------------------------------------------------
>
> Key: STORM-1073
> URL: https://issues.apache.org/jira/browse/STORM-1073
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hdfs
> Reporter: Aaron Dossett
> Assignee: Aaron Dossett
>
> SequenceFileBolt has the same issues that HdfsBolt has in STORM-969. This is
> also an opportunity to refactor AbstractHdfsBolt to most efficiently include
> these changes:
> Abstract HdfsBolt should define a concrete execute method and define abstract
> methods for:
> - writing a tuple
> - syncronizing file output
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
