[
https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947104#comment-14947104
]
ASF GitHub Bot commented on STORM-1084:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-146246638
@jerrypeng
I keep going back and forth on how we want the annotations to work. Right
now they are more or less a one to one translation of what we had before.
Admittedly it is a lot cleaner than it was before, but I almost want to combine
some of the validators together. Like
```
@IntegerValidator(min=0, nullAllowed=true)
public static final String SOME_CONFIG="some.config";
```
instead of
```
@PositiveIntegerValidator
public static final String SOME_CONFIG="some.config";
```
I'm also not sure about having validator at the end of each annotation.
But I don't think we can have a validator named the same as a common class. I
want to think this through a bit more.
> Improve Storm config validation process to use java annotations instead of
> *_SCHEMA format
> ------------------------------------------------------------------------------------------
>
> Key: STORM-1084
> URL: https://issues.apache.org/jira/browse/STORM-1084
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Boyang Jerry Peng
> Assignee: Boyang Jerry Peng
>
> So currently we specify validators:
> public static final String STORM_MESSAGING_NETTY_MIN_SLEEP_MS =
> "storm.messaging.netty.min_wait_ms";
> public static final Object STORM_MESSAGING_NETTY_MIN_SLEEP_MS_SCHEMA =
> ConfigValidation.IntegerValidator;
> A better way to do this is using annotations. Something like:
> @IntegerValidator
> public static final String STORM_MESSAGING_NETTY_MIN_SLEEP_MS =
> "storm.messaging.netty.min_wait_ms";
> Do this has many advantages. For one you can stack multiple annotations:
> @IntegerValidator
> @NotNull
> public static final String STORM_MESSAGING_NETTY_MIN_SLEEP_MS =
> "storm.messaging.netty.min_wait_ms";
> And we don't have to write another validator for strings that cannot be null
> And we can pass parameters into the annotations:
> @PositiveIntegerValidator(notNull=true)
> public static final String DRPC_REQUEST_TIMEOUT_SECS =
> "drpc.request.timeout.secs";
> instead of having to write another validator:
> ConfigValidation.NotNullPosIntegerValidator for checking for not null
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
