Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/795#issuecomment-147456715
The change itself looks OK, but I would like us to remove the
maxConnectionAttemtps member variable. It is not needed anymore, and it scares
me that we will regress again with it there. Additionally we should look at
updating the config.
```
/**
* Netty based messaging: The max # of retries that a peer will perform
when a remote is not accessible
*/
public static final String STORM_MESSAGING_NETTY_MAX_RETRIES =
"storm.messaging.netty.max_retries";
public static final Object STORM_MESSAGING_NETTY_MAX_RETRIES_SCHEMA =
ConfigValidation.IntegerValidator;
```
Describes what the config was doing, but that is fundamentally flawed. It
would be nice to deprecate this and file a follow on JIRA so that we can use a
better named/documented config in the backoff calculation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
