Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/795#discussion_r41902116
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -134,7 +128,7 @@
LOG.info("creating Netty Client, connecting to {}:{}, bufferSize:
{}", host, port, bufferSize);
int messageBatchSize =
Utils.getInt(stormConf.get(Config.STORM_NETTY_MESSAGE_BATCH_SIZE), 262144);
- maxReconnectionAttempts =
Utils.getInt(stormConf.get(Config.STORM_MESSAGING_NETTY_MAX_RETRIES));
+ int maxReconnectionAttempts =
Utils.getInt(stormConf.get(Config.STORM_MESSAGING_NETTY_MAX_RETRIES));
--- End diff --
If this config does not make sense anymore, should we stop using it in the
code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
