[
https://issues.apache.org/jira/browse/STORM-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953311#comment-14953311
]
ASF GitHub Bot commented on STORM-1106:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/795#issuecomment-147456715
The change itself looks OK, but I would like us to remove the
maxConnectionAttemtps member variable. It is not needed anymore, and it scares
me that we will regress again with it there. Additionally we should look at
updating the config.
```
/**
* Netty based messaging: The max # of retries that a peer will perform
when a remote is not accessible
*/
public static final String STORM_MESSAGING_NETTY_MAX_RETRIES =
"storm.messaging.netty.max_retries";
public static final Object STORM_MESSAGING_NETTY_MAX_RETRIES_SCHEMA =
ConfigValidation.IntegerValidator;
```
Describes what the config was doing, but that is fundamentally flawed. It
would be nice to deprecate this and file a follow on JIRA so that we can use a
better named/documented config in the backoff calculation
> Netty Client Connection Attempts should not be limited
> ------------------------------------------------------
>
> Key: STORM-1106
> URL: https://issues.apache.org/jira/browse/STORM-1106
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 0.10.0
> Reporter: Kishor Patil
> Assignee: Kishor Patil
> Priority: Blocker
>
> The workers should not give-up making connection with other workers. This
> could cause the worker to be blocked forever.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
