[
https://issues.apache.org/jira/browse/STORM-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955397#comment-14955397
]
ASF GitHub Bot commented on STORM-1106:
---------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/795#discussion_r41903879
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -134,7 +128,7 @@
LOG.info("creating Netty Client, connecting to {}:{}, bufferSize:
{}", host, port, bufferSize);
int messageBatchSize =
Utils.getInt(stormConf.get(Config.STORM_NETTY_MESSAGE_BATCH_SIZE), 262144);
- maxReconnectionAttempts =
Utils.getInt(stormConf.get(Config.STORM_MESSAGING_NETTY_MAX_RETRIES));
+ int maxReconnectionAttempts =
Utils.getInt(stormConf.get(Config.STORM_MESSAGING_NETTY_MAX_RETRIES));
--- End diff --
> It would be nice to deprecate this and file a follow on JIRA so that we
can use a better named/documented config in the backoff calculation
Disregard: I see from the above comment what we intend to do.
> Netty Client Connection Attempts should not be limited
> ------------------------------------------------------
>
> Key: STORM-1106
> URL: https://issues.apache.org/jira/browse/STORM-1106
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 0.10.0
> Reporter: Kishor Patil
> Assignee: Kishor Patil
> Priority: Blocker
>
> The workers should not give-up making connection with other workers. This
> could cause the worker to be blocked forever.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
