[ 
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958878#comment-14958878
 ] 

ASF GitHub Bot commented on STORM-1057:
---------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/753#issuecomment-148382991
  
    @wangli1426 
    
    Thrift classes have two options for member variables.  required and 
optional.  If you mark a member as required it must be there or thrift will 
throw an exception before serializing/deserializing it.  This becomes a problem 
if we want to do a rolling upgrade (upgrade the cluster with no downtime).  In 
that case we upgrade one daemon at a time, and there will be a period of time 
when old clients are talking to new servers and/or new clients are talking to 
old servers.  If we add new required fields to thrift classes then the code 
will break during the upgrade.  However, if we mark them all as optional and 
write the code in the client so it does not break if it gets a null for this 
value, then we will be OK.
    
    I don't want to break a rolling upgrade just so we can have a rate in the 
UI.


> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
>                 Key: STORM-1057
>                 URL: https://issues.apache.org/jira/browse/STORM-1057
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Li Wang
>            Assignee: Li Wang
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance 
> bottleneck of a topology. Displaying the throughputs of components and tasks 
> on the web ui could greatly facilitate the user identifying the performance 
> bottleneck and checking whether the the workload among components and tasks 
> are balanced. 
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to