[ 
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960710#comment-14960710
 ] 

ASF GitHub Bot commented on STORM-1057:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/753#discussion_r42243012
  
    --- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
    @@ -626,7 +638,8 @@
       (let [^CommonAggregateStats cas (.get_common_stats stats)]
         {"stream" stream-id
          "emitted" (nil-to-zero (.get_emitted cas))
    -     "transferred" (nil-to-zero (.get_transferred cas))}))
    +     "transferred" (nil-to-zero (.get_transferred cas))
    +     "throughput" (float-str (.get_throughput cas))}))
    --- End diff --
    
    I think we need nil-to-zero here as well, unless float-str will do that 
already


> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
>                 Key: STORM-1057
>                 URL: https://issues.apache.org/jira/browse/STORM-1057
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Li Wang
>            Assignee: Li Wang
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance 
> bottleneck of a topology. Displaying the throughputs of components and tasks 
> on the web ui could greatly facilitate the user identifying the performance 
> bottleneck and checking whether the the workload among components and tasks 
> are balanced. 
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to