[
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967756#comment-14967756
]
ASF GitHub Bot commented on STORM-1057:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/753#discussion_r42673357
--- Diff: storm-core/src/clj/backtype/storm/stats.clj ---
@@ -277,15 +277,34 @@
(value-stats stats SPOUT-FIELDS)
{:type :spout}))
+(defn values-divided-by [pairs t]
+ (let [update-values (fn [m f & args]
+ (into {} (for [[k v] m] [k (apply f v args)])))]
+ (update-values pairs / (double t))))
--- End diff --
I would prefer to see update-values be a regular function instead of
defined each time value-divide-by is called.
> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
> Key: STORM-1057
> URL: https://issues.apache.org/jira/browse/STORM-1057
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Li Wang
> Assignee: Li Wang
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance
> bottleneck of a topology. Displaying the throughputs of components and tasks
> on the web ui could greatly facilitate the user identifying the performance
> bottleneck and checking whether the the workload among components and tasks
> are balanced.
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
