Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/822#discussion_r43154970
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/logviewer.clj ---
    @@ -219,7 +321,7 @@ Note that if anything goes wrong, this will throw an 
Error and exit."
         (if (and appender-name appender (instance? RollingFileAppender 
appender))
           (.getParent (File. (.getFileName appender)))
           (throw
    -       (RuntimeException. "Log viewer could not find configured appender, 
or the appender is not a FileAppender. Please check that the appender name 
configured in storm and log4j2 agree.")))))
    +       (RuntimeException. "Log viewer could not find configured appender, 
or the appender is not a FileAppender. Please check that the appender name 
configured in storm and logback agree.")))))
    --- End diff --
    
    This exception should be log4j2 not logback


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to