Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/822#discussion_r43398696
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/logviewer.clj ---
    @@ -294,9 +418,55 @@ Note that if anything goes wrong, this will throw an 
Error and exit."
             (resp/status 404))
           (unauthorized-user-html user))))
     
    +(defn daemonlog-page [fname start length grep user root-dir]
    +  (if (or (blank? (*STORM-CONF* UI-FILTER))
    +        (authorized-log-user? user fname *STORM-CONF*)) ;; how to deal 
with this???????????
    --- End diff --
    
    I think we can remove this comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to