[ 
https://issues.apache.org/jira/browse/STORM-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976782#comment-14976782
 ] 

ASF GitHub Bot commented on STORM-901:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/822#discussion_r43154970
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/logviewer.clj ---
    @@ -219,7 +321,7 @@ Note that if anything goes wrong, this will throw an 
Error and exit."
         (if (and appender-name appender (instance? RollingFileAppender 
appender))
           (.getParent (File. (.getFileName appender)))
           (throw
    -       (RuntimeException. "Log viewer could not find configured appender, 
or the appender is not a FileAppender. Please check that the appender name 
configured in storm and log4j2 agree.")))))
    +       (RuntimeException. "Log viewer could not find configured appender, 
or the appender is not a FileAppender. Please check that the appender name 
configured in storm and logback agree.")))))
    --- End diff --
    
    This exception should be log4j2 not logback


> Worker Artifacts Directory
> --------------------------
>
>                 Key: STORM-901
>                 URL: https://issues.apache.org/jira/browse/STORM-901
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Zhuo Liu
>
> At Yahoo we have added in a separate directory that stores a workers log 
> files, but also provides a place where the worker can place other files that 
> it might help with debugging.  It is a new directory in the current working 
> directory of the worker process.  The files in there are cleaned up if they 
> get too large, but provides a place for heap dumps GC logs, etc.
> This work is already done, but needs to be put back into open source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to