[ 
https://issues.apache.org/jira/browse/STORM-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976788#comment-14976788
 ] 

ASF GitHub Bot commented on STORM-901:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/822#discussion_r43155407
  
    --- Diff: storm-core/src/clj/backtype/storm/util.clj ---
    @@ -580,6 +582,21 @@
         (when-not success?
           (throw (RuntimeException. (str "Failed to touch " path))))))
     
    +(defn create-symlink!
    +  "Create symlink is to the target"
    +  ([path-dir target-dir file-name]
    +    (create-symlink! path-dir target-dir file-name file-name))
    +  ([path-dir target-dir from-file-name to-file-name]
    +    (let [path (str path-dir file-path-separator from-file-name)
    +          target (str target-dir file-path-separator to-file-name)
    +          empty-array (make-array String 0)
    +          attrs (make-array FileAttribute 0)
    +          abs-path (.toAbsolutePath (Paths/get path empty-array))
    +          abs-target (.toAbsolutePath (Paths/get target empty-array))]
    +      (log-message "Creating symlink [" abs-path "] to [" abs-target "]")
    --- End diff --
    
    This should probably be debug if we keep it around at all.


> Worker Artifacts Directory
> --------------------------
>
>                 Key: STORM-901
>                 URL: https://issues.apache.org/jira/browse/STORM-901
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Zhuo Liu
>
> At Yahoo we have added in a separate directory that stores a workers log 
> files, but also provides a place where the worker can place other files that 
> it might help with debugging.  It is a new directory in the current working 
> directory of the worker process.  The files in there are cleaned up if they 
> get too large, but provides a place for heap dumps GC logs, etc.
> This work is already done, but needs to be put back into open source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to