[
https://issues.apache.org/jira/browse/STORM-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979820#comment-14979820
]
ASF GitHub Bot commented on STORM-1052:
---------------------------------------
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/743#discussion_r43349319
--- Diff:
external/storm-kafka/src/test/storm/kafka/TridentKafkaTopology.java ---
@@ -88,11 +88,11 @@ public static void main(String[] args) throws Exception
{
private static Config getConfig(String brokerConnectionString) {
Config conf = new Config();
- Map config = new HashMap();
Properties props = new Properties();
- props.put("metadata.broker.list", brokerConnectionString);
- props.put("request.required.acks", "1");
- props.put("serializer.class", "kafka.serializer.StringEncoder");
+ props.put("bootstrap.servers", brokerConnectionString);
+ props.put("acks", "1");
+ props.put("key.serializer",
"org.apache.kafka.common.serialization.StringSerializer");
--- End diff --
Sorry I took so long to respond. I think it is unnecessary for UT.
> TridentKafkaState uses new Kafka Producer API
> ---------------------------------------------
>
> Key: STORM-1052
> URL: https://issues.apache.org/jira/browse/STORM-1052
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Reporter: Xin Wang
> Assignee: Xin Wang
>
> use new kafka-clients api
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
