[ 
https://issues.apache.org/jira/browse/STORM-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990985#comment-14990985
 ] 

ASF GitHub Bot commented on STORM-1052:
---------------------------------------

Github user vesense commented on a diff in the pull request:

    https://github.com/apache/storm/pull/743#discussion_r43970097
  
    --- Diff: 
external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaState.java ---
    @@ -83,8 +81,8 @@ public void updateState(List<TridentTuple> tuples, 
TridentCollector collector) {
                     topic = topicSelector.getTopic(tuple);
     
                     if(topic != null) {
    -                    producer.send(new KeyedMessage(topic, 
mapper.getKeyFromTuple(tuple),
    -                            mapper.getMessageFromTuple(tuple)));
    +                    producer.send(new ProducerRecord(topic, 
mapper.getKeyFromTuple(tuple),
    --- End diff --
    
    Good catch. I will fix it. Thx.


> TridentKafkaState uses new Kafka Producer API
> ---------------------------------------------
>
>                 Key: STORM-1052
>                 URL: https://issues.apache.org/jira/browse/STORM-1052
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-kafka
>            Reporter: Xin Wang
>            Assignee: Xin Wang
>
> use new kafka-clients api



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to