[ 
https://issues.apache.org/jira/browse/STORM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983270#comment-14983270
 ] 

ASF GitHub Bot commented on STORM-1153:
---------------------------------------

GitHub user sureshms opened a pull request:

    https://github.com/apache/storm/pull/837

    STORM-1153 Use static final instead of just static for class members

    Along with making static variables, I have also cleaned up the code in 
those files. Especially around reducing code verbosity by using Generic Type 
Inference.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sureshms/incubator-storm STORM-1153

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #837
    
----
commit 1ef7f3dceddff566de6c61d7bb619702e459e230
Author: Suresh Srinivas <[email protected]>
Date:   2015-10-30T20:38:07Z

    STORM-1153 Use static final instead of just static for class members

----


> Use static final instead of just static for class members
> ---------------------------------------------------------
>
>                 Key: STORM-1153
>                 URL: https://issues.apache.org/jira/browse/STORM-1153
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Minor
>
> Many variables, especially loggers should be declared as final variables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to