[
https://issues.apache.org/jira/browse/STORM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994213#comment-14994213
]
ASF GitHub Bot commented on STORM-1153:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/837#issuecomment-154500817
+1 the changes look good.
> Use static final instead of just static for class members
> ---------------------------------------------------------
>
> Key: STORM-1153
> URL: https://issues.apache.org/jira/browse/STORM-1153
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
>
> Many variables, especially loggers should be declared as final variables
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)