[ 
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987824#comment-14987824
 ] 

ASF GitHub Bot commented on STORM-876:
--------------------------------------

Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/845#discussion_r43787675
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
    @@ -346,53 +394,124 @@
           [(.getNodeId slot) (.getPort slot)]
           )))
     
    +(defn- get-nimbus-subject []
    +  (let [nimbus-subject (Subject.)
    +        nimbus-principal (NimbusPrincipal.)
    +        principals (.getPrincipals nimbus-subject)]
    +    (.add principals nimbus-principal)
    +    nimbus-subject))
    +
    +(defn- get-metadata-version [blob-store key subject]
    +  (let [blob-meta (.getBlobMeta blob-store key subject)]
    +    (.get_version blob-meta)))
    +
    +(defn get-key-list-from-blob-store [blob-store]
    +  (let [key-iter (.listKeys blob-store (get-nimbus-subject))
    +        keys (iterator-seq key-iter)]
    +    (if (not-nil? keys)
    +      (java.util.ArrayList. keys)
    +      [])))
    --- End diff --
    
    Here in one place you're returning a java ArrayList, and in the other 
you're returning a clojure vector.


> Dist Cache: Basic Functionality
> -------------------------------
>
>                 Key: STORM-876
>                 URL: https://issues.apache.org/jira/browse/STORM-876
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf
>
>
> Basic functionality for the Dist Cache feature.
> As part of this a new API should be added to support uploading and 
> downloading dist cache items.  storm-core.ser, storm-conf.ser and storm.jar 
> should be written into the blob store instead of residing locally. We need a 
> default implementation of the blob store that does essentially what nimbus 
> currently does and does not need anything extra.  But having an HDFS backend 
> too would be great for scalability and HA.
> The supervisor should provide a way to download and manage these blobs and 
> provide a working directory for the worker process with symlinks to the 
> blobs.  It should also allow the blobs to be updated and switch the symlink 
> atomically to point to the new blob once it is downloaded.
> All of this is already done by code internal to Yahoo! we are in the process 
> of getting it ready to push back to open source shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to