Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/848#discussion_r43794932
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -843,14 +870,21 @@
(populate-context! servlet-request)
(assert-authorized-user "getClusterInfo")
(json-response (nimbus-summary) (:callback m)))
+ (GET "/api/v1/history/summary" [:as {:keys [cookies servlet-request]} &
m]
+ (let [user (.getUserName http-creds-handler servlet-request)]
+ (json-response (topology-history-info user) (:callback m))))
(GET "/api/v1/supervisor/summary" [:as {:keys [cookies servlet-request]}
& m]
- (populate-context! servlet-request)
- (assert-authorized-user "getClusterInfo")
- (json-response (supervisor-summary) (:callback m)))
+ (assert-authorized-user servlet-request "getClusterInfo")
--- End diff --
This needs to stay as populate-context! before calling
assert-authorized-user, or the code will fail when security is enabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
