Github user zhuoliu commented on a diff in the pull request:

    https://github.com/apache/storm/pull/848#discussion_r43799518
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/logviewer.clj ---
    @@ -476,6 +485,405 @@ Note that if anything goes wrong, this will throw an 
Error and exit."
           (-> (resp/response "Page not found")
               (resp/status 404)))))
     
    +(def grep-max-search-size 1024)
    +(def grep-buf-size 2048)
    +(def grep-context-size 128)
    +
    +(defn logviewer-port
    --- End diff --
    
    We have it have a function mostly for mocking.
    logviewer_test.clj
    let[expected-port 8888]
        (stubbing [local-hostname expected-host
                   logviewer/logviewer-port expected-port]
         .................


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to