[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988208#comment-14988208
]
ASF GitHub Bot commented on STORM-876:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r43812156
--- Diff: storm-core/src/clj/backtype/storm/cluster.clj ---
@@ -436,18 +445,27 @@
(set-ephemeral-node cluster-state (nimbus-path nimbus-id)
(Utils/serialize nimbus-summary) acls))
- (code-distributor-info
- [this storm-id]
- (map (fn [nimbus-info] (NimbusInfo/parse nimbus-info))
- (let [path (code-distributor-path storm-id)]
- (do
- (sync-path cluster-state path)
- (get-children cluster-state path false)))))
+ (blobstore-key-details
+ [this]
+ (do
+ (sync-path cluster-state BLOBSTORE-SUBTREE)
+ (get-children cluster-state BLOBSTORE-SUBTREE false)))
+
+ (blobstore-info
+ [this blob-key]
+ (let [path (blobstore-path blob-key)]
+ (do
+ (sync-path cluster-state path)
+ (get-children cluster-state path false))))
--- End diff --
Remove `do`
> Dist Cache: Basic Functionality
> -------------------------------
>
> Key: STORM-876
> URL: https://issues.apache.org/jira/browse/STORM-876
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf
>
>
> Basic functionality for the Dist Cache feature.
> As part of this a new API should be added to support uploading and
> downloading dist cache items. storm-core.ser, storm-conf.ser and storm.jar
> should be written into the blob store instead of residing locally. We need a
> default implementation of the blob store that does essentially what nimbus
> currently does and does not need anything extra. But having an HDFS backend
> too would be great for scalability and HA.
> The supervisor should provide a way to download and manage these blobs and
> provide a working directory for the worker process with symlinks to the
> blobs. It should also allow the blobs to be updated and switch the symlink
> atomically to point to the new blob once it is downloaded.
> All of this is already done by code internal to Yahoo! we are in the process
> of getting it ready to push back to open source shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
