[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988178#comment-14988178
]
ASF GitHub Bot commented on STORM-876:
--------------------------------------
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r43810519
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -1035,30 +1150,28 @@
(catch Exception e
(throw (AuthorizationException. (str "Invalid file path: "
file-path))))))
-(defn try-read-storm-conf [conf storm-id]
+(defn try-read-storm-conf [conf storm-id blob-store]
(try-cause
- (read-storm-conf conf storm-id)
- (catch FileNotFoundException e
- (throw (NotAliveException. (str storm-id))))
- )
-)
+ (read-storm-conf-as-nimbus storm-id blob-store)
+ (catch KeyNotFoundException e
+ (throw (NotAliveException. (str storm-id))))))
(defn try-read-storm-conf-from-name [conf storm-name nimbus]
(let [storm-cluster-state (:storm-cluster-state nimbus)
+ blob-store (:blob-store nimbus)
id (get-storm-id storm-cluster-state storm-name)]
- (try-read-storm-conf conf id)))
+ (try-read-storm-conf conf id blob-store)))
--- End diff --
indentation
> Dist Cache: Basic Functionality
> -------------------------------
>
> Key: STORM-876
> URL: https://issues.apache.org/jira/browse/STORM-876
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf
>
>
> Basic functionality for the Dist Cache feature.
> As part of this a new API should be added to support uploading and
> downloading dist cache items. storm-core.ser, storm-conf.ser and storm.jar
> should be written into the blob store instead of residing locally. We need a
> default implementation of the blob store that does essentially what nimbus
> currently does and does not need anything extra. But having an HDFS backend
> too would be great for scalability and HA.
> The supervisor should provide a way to download and manage these blobs and
> provide a working directory for the worker process with symlinks to the
> blobs. It should also allow the blobs to be updated and switch the symlink
> atomically to point to the new blob once it is downloaded.
> All of this is already done by code internal to Yahoo! we are in the process
> of getting it ready to push back to open source shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
