[
https://issues.apache.org/jira/browse/STORM-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990182#comment-14990182
]
ASF GitHub Bot commented on STORM-1158:
---------------------------------------
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/850#discussion_r43922551
--- Diff: storm-core/src/clj/backtype/storm/daemon/logviewer.clj ---
@@ -39,10 +39,18 @@
[ring.util.codec :as codec]
[ring.util.response :as resp]
[clojure.string :as string])
+ (:require [metrics.meters :refer [defmeter mark!]])
+ (:use [backtype.storm.daemon.common :only [start-metrics-reporters]])
(:gen-class))
(def ^:dynamic *STORM-CONF* (read-storm-config))
+(defmeter num:logviewer-log-page-httpRequests)
+(defmeter num:logviewer-daemonlog-page-httpRequests)
+(defmeter num:logviewer-download-log-file-httpRequests)
+(defmeter num:logviewer-download-log-daemon-file-httpRequests)
+(defmeter num:logviewer-list-logs-httpRequests)
--- End diff --
camel case and clojure naming convention in the same line? httpRequests
> Storm metrics to profile various storm functions
> ------------------------------------------------
>
> Key: STORM-1158
> URL: https://issues.apache.org/jira/browse/STORM-1158
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Boyang Jerry Peng
> Assignee: Boyang Jerry Peng
>
> It would be nice to have mechanism that would user to collect performance
> stats on various storm internal actions such as thrift API call and http
> requests. This will allow users to understand better the performance of
> many of Storm's internal as well as potentially identifying performance
> problems and bottlenecks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
