[ 
https://issues.apache.org/jira/browse/STORM-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990398#comment-14990398
 ] 

ASF GitHub Bot commented on STORM-1158:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/850#discussion_r43938005
  
    --- Diff: storm-core/pom.xml ---
    @@ -602,6 +612,42 @@
                               <pattern>org.eclipse.jetty</pattern>
                               
<shadedPattern>org.apache.storm.shade.org.eclipse.jetty</shadedPattern>
                             </relocation>
    +                        <relocation>
    +                            <pattern>com.codahale.metrics</pattern>
    +                            
<shadedPattern>org.apache.storm.shade.com.codahale.metrics</shadedPattern>
    +                        </relocation>
    --- End diff --
    
    If we are shading the codahale API the normal way of installing a custom 
metrics reporter is not going to work.  We should probably look at either not 
shading this, or at providing instructions on how to make other Reporters work. 
 But that can probably be in a follow on JIRA.


> Storm metrics to profile various storm functions
> ------------------------------------------------
>
>                 Key: STORM-1158
>                 URL: https://issues.apache.org/jira/browse/STORM-1158
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Boyang Jerry Peng
>            Assignee: Boyang Jerry Peng
>
> It would be nice to have mechanism that would user to collect performance 
> stats on various storm internal actions such as thrift API call and http 
> requests.  This will allow users to understand  better the performance of 
> many of Storm's internal as well as potentially identifying performance 
> problems and bottlenecks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to