[ 
https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990408#comment-14990408
 ] 

ASF GitHub Bot commented on STORM-885:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/838#discussion_r43938663
  
    --- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
    @@ -0,0 +1,248 @@
    +;; Licensed to the Apache Software Foundation (ASF) under one
    +;; or more contributor license agreements.  See the NOTICE file
    +;; distributed with this work for additional information
    +;; regarding copyright ownership.  The ASF licenses this file
    +;; to you under the Apache License, Version 2.0 (the
    +;; "License"); you may not use this file except in compliance
    +;; with the License.  You may obtain a copy of the License at
    +;;
    +;; http://www.apache.org/licenses/LICENSE-2.0
    +;;
    +;; Unless required by applicable law or agreed to in writing, software
    +;; distributed under the License is distributed on an "AS IS" BASIS,
    +;; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +;; See the License for the specific language governing permissions and
    +;; limitations under the License.
    +
    +(ns org.apache.storm.pacemaker.pacemaker
    +  (:import [org.apache.storm.pacemaker PacemakerServer 
IServerMessageHandler]
    +           [java.util.concurrent ConcurrentHashMap ThreadPoolExecutor 
TimeUnit LinkedBlockingDeque]
    +           [java.util.concurrent.atomic AtomicInteger]
    +           [java.util Date]
    +           [backtype.storm.generated
    +            HBAuthorizationException HBExecutionException HBNodes HBRecords
    +            HBServerMessageType HBMessage HBMessageData HBPulse])
    +  (:use [clojure.string :only [replace-first split]]
    +        [backtype.storm log config util])
    +  (:require [clojure.java.jmx :as jmx])
    +  (:gen-class))
    +
    +;; This is the old Thrift service that this server is emulating.
    --- End diff --
    
    Its not really old.  And can you explain why you are emulating a thrift 
service instead of using thrift?


> Heartbeat Server (Pacemaker)
> ----------------------------
>
>                 Key: STORM-885
>                 URL: https://issues.apache.org/jira/browse/STORM-885
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Kyle Nusbaum
>
> Large highly connected topologies and large clusters write a lot of data into 
> ZooKeeper.  The heartbeats, that make up the majority of this data, do not 
> need to be persisted to disk.  Pacemaker is intended to be a secure 
> replacement for storing the heartbeats without changing anything within the 
> heartbeats.  In the future as more metrics are added in, we may want to look 
> into switching it over to look more like Heron, where a metrics server is 
> running for each node/topology.  And can be used to aggregate/per-aggregate 
> them in a more scalable manor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to