[ https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990633#comment-14990633 ]
ASF GitHub Bot commented on STORM-885: -------------------------------------- Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43952914 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Context.java --- @@ -55,6 +54,7 @@ public void prepare(Map storm_conf) { int maxWorkers = Utils.getInt(storm_conf.get(Config.STORM_MESSAGING_NETTY_CLIENT_WORKER_THREADS)); ThreadFactory bossFactory = new NettyRenameThreadFactory("client" + "-boss"); ThreadFactory workerFactory = new NettyRenameThreadFactory("client" + "-worker"); + // TODO investigate impact of having one worker --- End diff -- I don't think we need this. I'm pretty sure this is a merge error / regression. > Heartbeat Server (Pacemaker) > ---------------------------- > > Key: STORM-885 > URL: https://issues.apache.org/jira/browse/STORM-885 > Project: Apache Storm > Issue Type: Improvement > Components: storm-core > Reporter: Robert Joseph Evans > Assignee: Kyle Nusbaum > > Large highly connected topologies and large clusters write a lot of data into > ZooKeeper. The heartbeats, that make up the majority of this data, do not > need to be persisted to disk. Pacemaker is intended to be a secure > replacement for storing the heartbeats without changing anything within the > heartbeats. In the future as more metrics are added in, we may want to look > into switching it over to look more like Heron, where a metrics server is > running for each node/topology. And can be used to aggregate/per-aggregate > them in a more scalable manor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)