Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/849#issuecomment-153917289
the code is fine to me, but this is the first step to do health check:
(1) where put the script, we had better put the script under
$STORM_HOME/healthcheck, because when install storm, the script will be also
installed in every node.
(2) the script depends on OS, in Windows, they should be xxx, in Linux,
they should be XXX;
maybe we need some OS detect action to judge what kind of OS is running. so
in the "STORM_HEALTH_CHECK_DIR" dir, there are several directory,
windows/linux/mac, different OS use different dir.
(3) could you please help to implement healthcheck.clj with java. in a
short while, the storm will contain two core, one is clojure, the other is
java. so could you please help to implement healthcheck.clj.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
