Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/849#issuecomment-154127266
  
    @longdafeng it might be nice in the future to have some "standard" health 
check scripts come with storm, but honestly even with just Linux, it is 
difficult to come up with something that will work on all Linux distros, or 
even on all boxes with the same distro.
    
    The things I see as potential issues would be the network card fell back to 
100Mbit.  But that does not work if you are running on old 100Mbit hardware, or 
what if for some reason you are using infiniband, with a 100Mbit control path.  
Or if you are using bonded NICs?  There are too many variables in my opinion to 
really make a lot of these generic.
    
    The default directory is `$STORM_HOME/healthcheck` already.  Directories 
are usually relative to $STORM_HOME, but there have been a few cases where we 
needed to make it explicit.  @zhuoliu you did a lot of work around resolving 
relative paths in configs.  could you take a look at this and see if we need to 
change anything to make this work so it is always relative to `$STORM_HOME`/?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to