Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/862#discussion_r44148807
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
    @@ -124,6 +124,8 @@
          :id->sched-status (atom {})
          :cred-renewers (AuthUtils/GetCredentialRenewers conf)
          :nimbus-autocred-plugins (AuthUtils/getNimbusAutoCredPlugins conf)
    +     :nimbus-topology-action-notifier (when-not (clojure.string/blank? 
(conf NIMBUS-TOPOLOGY-ACTION-NOTIFIER-PLUGIN))
    +                                        (new-instance (conf 
NIMBUS-TOPOLOGY-ACTION-NOTIFIER-PLUGIN)))
    --- End diff --
    
    we need call prepare and catch any errors so that we don't bring nimbus 
down.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to