Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/862#discussion_r44304729
--- Diff:
storm-core/test/jvm/backtype/storm/nimbus/InMemoryTopologyAcitonNotifier.java
---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.nimbus;
+
+import java.util.Map;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.HashMap;
+
+public class InMemoryTopologyAcitonNotifier implements
ITopologyActionNotifierPlugin {
--- End diff --
I don't like this class either. I tried just stubbing out but given the
config is just the string and the actual instance is created using reflection
my only option were to either stub notify-topology-action-listener, which is
the method I am trying to test. I also tried stubbing nimbus-data which holds
the reference to the actual instance but for one reason or another nimbus just
failed to start with that stubbing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
