[
https://issues.apache.org/jira/browse/STORM-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001296#comment-15001296
]
ASF GitHub Bot commented on STORM-1030:
---------------------------------------
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44600086
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
collector.ack(t);
tupleBatch.clear();
}
+ } catch(SerializationError se) {
+ LOG.info("Serialization exception occurred, tuple is
acknowledged but not written to Hive.", tuple);
+ collector.ack(tuple);
--- End diff --
@revans2 Hive SerializationError means the tuple fields to table column
mapping is nto right. For example if table has 6 rows and this tuple has only 5
fields than it can throw SerializationError. In this case instead of failing
the tuple and keep re-running into this error. Its better we ack and log an
error.
hiveWriter.write will throw an error on the current tuple and it wil be not
be added to the tupleBatch. Since this is only happening for current the other
tuples in the batch are good and we can still proceed writing them to hive.
> Hive Connector Fixes
> --------------------
>
> Key: STORM-1030
> URL: https://issues.apache.org/jira/browse/STORM-1030
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hive
> Reporter: Sriharsha Chintalapani
> Assignee: Sriharsha Chintalapani
> Fix For: 0.11.0
>
>
> 1. Schedule Hive transaction heartbeats outside of execute method.
> 2. Fix retiring idleWriters
> 3. Do not call flush if there is no data added to a txnbatch
> 4. Catch any exception and abort transaction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
